Fix creation of custom image clusters and correctly handles upgrades … #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rigazilla
approved these changes
Sep 13, 2024
| // as the server components are not changed. | ||
| customImage := i.Status.Operand.CustomImage | ||
| if !customImage && requestedOperand.CVE && installedOperand.UpstreamVersion.EQ(*requestedOperand.UpstreamVersion) { | ||
| // If the Operand is marked as a CVE base-image release and no custom image is installed/requested, then we perform the |
There was a problem hiding this comment.
I'm missing something here?
the comment says 'perform upgrade' but the return value is false
There was a problem hiding this comment.
This method returns true if a Graceful/HR Rolling upgrade is required. In this case we turn false, as the statefulset_updates.go handler will trigger a StatefulSet rolling upgrade instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.